-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Make optimizedText wrapper aware #132461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make optimizedText wrapper aware #132461
Conversation
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! LGTM
|
@elasticmachine test this please |
|
Oops sorry, just realized CI had already run. I saw the |
Before this change,
IndexRoutingwasn't able to fully take advantage ofoptimizedText. That's because it is using a non defaultXContentParserConfiguration(withFiltering), which creates a wrapper (FilteringParserDelegate). This prevented the parser to access theESUTF8StreamJsonParser.